Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 | BackCompat\Helper: fix implicitly nullable types deprecation notice #568

Merged
merged 1 commit into from
Mar 16, 2024

Commits on Mar 16, 2024

  1. PHP 8.4 | BackCompat\Helper: fix implicitly nullable types deprecatio…

    …n notice
    
    The `$phpcsFile` parameter is optional for the `getEncoding()` and the `ignoreAnnotations` method, but the type declaration cannot be made nullable as the minimum supported PHP version of this package is PHP 5.4, while PHP 7.1 is needed for the nullable operator.
    
    Removing the `File` type declaration effectively widens the type to `mixed`, which fixes the deprecation notice.
    
    As the class is `final`, this change does not constitute a BC-break.
    
    Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
    jrfnl committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    65c77b1 View commit details
    Browse the repository at this point in the history