-
-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tests/Tokenizer/DNFTypesTest: split the test class
... into two test classes, one targetting the `Tokenizer\PHP` class, one targetting the `Tokenizer\Tokenizer` class. While this does mean there is now some duplication between these test classes, I don't think that's problematic. It also allows for these tests to diverge based on the specific test needs for each of the classes under test.
- Loading branch information
Showing
4 changed files
with
567 additions
and
58 deletions.
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
185 changes: 185 additions & 0 deletions
185
tests/Core/Tokenizer/Tokenizer/CreateParenthesisNestingMapDNFTypesTest.inc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,185 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * Non-exhaustive code samples of "normal" parentheses. | ||
| */ | ||
|
|
||
| /* testParensNoOwner */ | ||
| $a = ( CONST_A & CONST_B ) | CONST_C === false; | ||
|
|
||
| /* testParensNoOwnerInTernary */ | ||
| $a = $var ? $something : CONST_C | ( CONST_A & CONST_B ); | ||
|
|
||
| /* testParensNoOwnerInShortTernary */ | ||
| $a = $var ?: ( CONST_A & CONST_B ); | ||
|
|
||
| /* testParensOwnerFunctionAmpersandInDefaultValue */ | ||
| function defaultValueLooksLikeDNF( mixed $param = (CONST_A&CONST_B) ) {} | ||
|
|
||
| /* testParensOwnerClosureAmpersandParamRef */ | ||
| $closureWithParamRef = function(&$param) {}; | ||
|
|
||
| /* testParensOwnerIf */ | ||
| if ( /* testParensNoOwnerInIfCondition */ CONST_C | ( CONST_A & /*comment*/ CONST_B ) > 10 ) {} | ||
|
|
||
| /* testParensOwnerFor */ | ||
| for ($i =0; $i < /* testParensNoOwnerInForCondition */ ( CONST_A & CONST_B ); $i++ ); | ||
|
|
||
| /* testParensOwnerMatch */ | ||
| $match = match(CONST_A & CONST_B) { | ||
| default => $a, | ||
| }; | ||
|
|
||
| /* testParensOwnerArray */ | ||
| $array = array ( | ||
| 'text', | ||
| \CONST_A & \Fully\Qualified\CONST_B, | ||
| /* testParensNoOwnerFunctionCallWithAmpersandInCallable */ | ||
| do_something($a, /* testParensOwnerArrowFn */ fn($b) => $a & $b, $c), | ||
| ); | ||
|
|
||
| /* testParensOwnerListWithRefVars */ | ||
| list(&$a, &$b) = $array; | ||
|
|
||
| /* testParensNoOwnerFunctionCallwithDNFLookALikeParam */ | ||
| $obj->static((CONST_A&CONST_B)|CONST_C | $var); | ||
|
|
||
|
|
||
| /* | ||
| * DNF parentheses. | ||
| */ | ||
|
|
||
| class DNFTypes { | ||
| /* testDNFTypeOOConstUnqualifiedClasses */ | ||
| public const (A&B)|D UNQUALIFIED = new Foo; | ||
|
|
||
| /* testDNFTypeOOConstReverseModifierOrder */ | ||
| protected final const int|(Foo&Bar)|float MODIFIERS_REVERSED /* testParensNoOwnerOOConstDefaultValue */ = (E_WARNING & E_NOTICE) | E_DEPRECATED; | ||
|
|
||
| const | ||
| /* testDNFTypeOOConstMulti1 */ | ||
| (A&B) | | ||
| /* testDNFTypeOOConstMulti2 */ | ||
| (C&D) | // phpcs:ignore Stnd.Cat.Sniff | ||
| /* testDNFTypeOOConstMulti3 */ | ||
| (Y&D) | ||
| | null MULTI_DNF = false; | ||
|
|
||
| /* testDNFTypeOOConstNamespaceRelative */ | ||
| final protected const (namespace\Sub\NameA&namespace\Sub\NameB)|namespace\Sub\NameC NAMESPACE_RELATIVE = new namespace\Sub\NameB; | ||
| /* testDNFTypeOOConstPartiallyQualified */ | ||
| const Partially\Qualified\NameC|(Partially\Qualified\NameA&Partially\Qualified\NameB) PARTIALLY_QUALIFIED = new Partially\Qualified\NameA; | ||
| /* testDNFTypeOOConstFullyQualified */ | ||
| const (\Fully\Qualified\NameA&\Fully\Qualified\NameB)|\Fully\Qualified\NameC FULLY_QUALIFIED = new \Fully\Qualified\NameB(); | ||
| /* testDNFTypePropertyUnqualifiedClasses */ | ||
| public static (Foo&Bar)|object $obj; | ||
| /* testDNFTypePropertyReverseModifierOrder */ | ||
| static protected string|(A&B)|bool $dnf /* testParensNoOwnerPropertyDefaultValue1 */ = ( E_WARNING & E_NOTICE ) | /* testParensNoOwnerPropertyDefaultValue2 */ (E_ALL & E_DEPRECATED); | ||
| private | ||
| /* testDNFTypePropertyMultiNamespaceRelative */ | ||
| (namespace\Sub\NameA&namespace\Sub\NameB) | | ||
| /* testDNFTypePropertyMultiPartiallyQualified */ | ||
| (Partially\Qualified\NameA&Partially\Qualified\NameB) | // phpcs:ignore Stnd.Cat.Sniff | ||
| false | ||
| /* testDNFTypePropertyMultiFullyQualified */ | ||
| | (\Fully\Qualified\NameA&\Fully\Qualified\NameB) $multiDnf; | ||
| /* testDNFTypePropertyWithReadOnlyKeyword1 */ | ||
| protected readonly (A&B) | /* testDNFTypePropertyWithReadOnlyKeyword2 */ (C&D) $readonly; | ||
| /* testDNFTypePropertyWithStaticAndReadOnlyKeywords */ | ||
| static readonly (A&B&C)|array $staticReadonly; | ||
| /* testDNFTypePropertyWithOnlyStaticKeyword */ | ||
| static (A&B&C)|true $obj; | ||
| public function paramTypes( | ||
| /* testDNFTypeParam1WithAttribute */ | ||
| #[MyAttribute] | ||
| (\Foo&Bar)|int|float $paramA /* testParensNoOwnerParamDefaultValue */ = SOMETHING | (CONSTANT_A & CONSTANT_B), | ||
| /* testDNFTypeParam2 */ | ||
| (Foo&\Bar) /* testDNFTypeParam3 */ |(Baz&Fop) &...$paramB = null, | ||
| ) { | ||
| /* testParensNoOwnerInReturnValue1 */ | ||
| return ( | ||
| /* testParensNoOwnerInReturnValue2 */ | ||
| ($a1 & $b1) | | ||
| /* testParensNoOwnerInReturnValue3 */ | ||
| ($a2 & $b2) | ||
| ) + $c; | ||
| } | ||
| public function identifierNames( | ||
| /* testDNFTypeParamNamespaceRelative */ | ||
| (namespace\Sub\NameA&namespace\Sub\NameB)|false $paramA, | ||
| /* testDNFTypeParamPartiallyQualified */ | ||
| Partially\Qualified\NameC|(Partially\Qualified\NameA&Partially\Qualified\NameB) $paramB, | ||
| /* testDNFTypeParamFullyQualified */ | ||
| name|(\Fully\Qualified\NameA&\Fully\Qualified\NameB) $paramC, | ||
| ) {} | ||
|
|
||
| public function __construct( | ||
| /* testDNFTypeConstructorPropertyPromotion1 */ | ||
| public (A&B)| /* testDNFTypeConstructorPropertyPromotion2 */ (A&D) $property | ||
| ) {} | ||
|
|
||
| public function returnType()/* testDNFTypeReturnType1 */ : A|(B&D)|/* testDNFTypeReturnType2 */(B&W)|null {} | ||
|
|
||
| abstract public function abstractMethod(): /* testDNFTypeAbstractMethodReturnType1 */ (X&Y) /* testDNFTypeAbstractMethodReturnType2 */ |(W&Z); | ||
|
|
||
| public function identifierNamesReturnRelative( | ||
| ) : /* testDNFTypeReturnTypeNamespaceRelative */ (namespace\Sub\NameA&namespace\Sub\NameB)|namespace\Sub\NameC {} | ||
|
|
||
| public function identifierNamesReturnPQ( | ||
| ) : /* testDNFTypeReturnPartiallyQualified */Partially\Qualified\NameA|(Partially\Qualified\NameB&Partially\Qualified\NameC) {} | ||
|
|
||
| // Illegal type: segments which are strict subsets of others are disallowed, but that's not the concern of the tokenizer. | ||
| public function identifierNamesReturnFQ( | ||
| ) /* testDNFTypeReturnFullyQualified */ : (\Fully\Qualified\NameA&\Fully\Qualified\NameB)|\Fully\Qualified\NameB {} | ||
| } | ||
|
|
||
| function globalFunctionWithSpreadAndReference( | ||
| /* testDNFTypeWithReference */ | ||
| float|(B&A) &$paramA, | ||
| /* testDNFTypeWithSpreadOperator */ | ||
| string|(B|D) ...$paramB | ||
| ) {} | ||
|
|
||
|
|
||
| $closureWithParamType = function ( /* testDNFTypeClosureParamIllegalNullable */ ?(A&B)|bool $string) {}; | ||
|
|
||
| /* testParensOwnerClosureAmpersandInDefaultValue */ | ||
| $closureWithReturnType = function ($string = NONSENSE & FAKE) /* testDNFTypeClosureReturn */ : (\Package\MyA&PackageB)|null {}; | ||
|
|
||
| /* testParensOwnerArrowDNFUsedWithin */ | ||
| $arrowWithParamType = fn ( | ||
| /* testDNFTypeArrowParam */ | ||
| object|(A&B&C)|array $param, | ||
| /* testParensNoOwnerAmpersandInDefaultValue */ ?int $int = (CONSTA & CONSTB )| CONST_C | ||
| ) | ||
| /* testParensNoOwnerInArrowReturnExpression */ | ||
| => ($param & $foo ) | $int; | ||
|
|
||
| $arrowWithReturnType = fn ($param) : /* testDNFTypeArrowReturnType */ int|(A&B) => $param * 10; | ||
|
|
||
| $arrowWithParamReturnByRef = fn &( | ||
| /* testDNFTypeArrowParamWithReturnByRef */ | ||
| (A&B)|null $param | ||
| ) => $param * 10; | ||
|
|
||
| function InvalidSyntaxes( | ||
| /* testDNFTypeParamIllegalUnnecessaryParens */ | ||
| (A&B) $parensNotNeeded | ||
|
|
||
| /* testDNFTypeParamIllegalIntersectUnionReversed */ | ||
| A&(B|D) $onlyIntersectAllowedWithinParensAndUnionOutside | ||
|
|
||
| /* testDNFTypeParamIllegalNestedParens */ | ||
| A|(B&(D|W)|null) $nestedParensNotAllowed | ||
| ) {} |
Oops, something went wrong.