Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minor release with Composer's replace directive to unblock switchover #116

Closed
sanmai opened this issue Dec 4, 2023 · 9 comments
Closed

Comments

@sanmai
Copy link

sanmai commented Dec 4, 2023

Is your feature request related to a problem?

There are many packages that depend on squizlabs/php_codesniffer and I can't install this package because the release version does not include Composer's replace directive added in #1.

Describe the solution you'd like

Please make a minor release such as 3.7.3 including changes from #1. Thanks!

@jrfnl
Copy link
Member

jrfnl commented Dec 4, 2023

@sanmai I hear what you are saying, but at the point I forked the repo quite a few things had already been merged for a 3.8.0 release.

So as per the announcement:

I will work on getting 3.8.0 released as soon as possible.

Note: I would recommend waiting to make the switch until the 3.8.0 release has been tagged. Watch releases on the new repo to automatically get notified of this. The changelog will contain the relevant information for making the switch.

The "as soon as possible" will hopefully mean "by the end of this week".

@sanmai
Copy link
Author

sanmai commented Dec 4, 2023

I understand the timeline is to push a new release at the end of the week. Yet it may have a breaking change or two, and they could require additional deliberation while the momentum is lost. What I'm proposing it to release 3.7.3 now at the peak of momentum, and let folks update like the normally would to 3.8.0.

I'm rooting for this project, and I find it despicable to see a dwindling momentum. Thank you for considering my request.

@jrfnl
Copy link
Member

jrfnl commented Dec 4, 2023

I understand the timeline is to push a new release at the end of the week. Yet it may have a breaking change or two, and they could require additional deliberation while the momentum is lost. What I'm proposing it to release 3.7.3 now at the peak of momentum, and let folks update like the normally would to 3.8.0.

@sanmai I'll keep it in mind. There are still some open questions about the replace directive at this moment (also see #113 and #114), so I'll check what's in the changelog before release and will decide then.

@yguedidi
Copy link

yguedidi commented Dec 4, 2023

@jrfnl maybe create a 3.7 branch that starts from the 3.7.2 tag, and then make the composer related PRs target the 3.7 branch, merge the PRs, release a 3.7.3 from the 3.7 branch, then merge the 3.7 in master, what do you think?

@derrabus
Copy link

derrabus commented Dec 4, 2023

All of you, please give @jrfnl some time. Until a new release is tagged from this repository, you won't gain anything from switching just yet.

@arokettu
Copy link

arokettu commented Dec 4, 2023

I have a small suggestion here

the replace directive was added as

    "replace": {
        "squizlabs/php_codesniffer": "> 2.0"
    },

shouldn't it be

    "replace": {
        "squizlabs/php_codesniffer": "self.version"
    },

?

@derrabus
Copy link

derrabus commented Dec 5, 2023

@arokettu see #113

@jrfnl
Copy link
Member

jrfnl commented Dec 6, 2023

Looks like this may not be needed after all - See #135

@jrfnl jrfnl added this to the 3.8.0 milestone Dec 6, 2023
@jrfnl
Copy link
Member

jrfnl commented Dec 6, 2023

Thank you everyone for pitching in, the package rename has been reverted. The package will continue under its original name, so this is no longer relevant.

@jrfnl jrfnl closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants