Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: revert package name change #135

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 6, 2023

Description

⚠️ To be merged once the Packagist edit has been made. ⚠️

This reverts commit f6dc841 and updates the information in the changelog for the 3.8.0 release.

Users who already changed the package name in their composer.json dependencies, should switch back to the original package name.

Refs:

Closes #113, #114, #116

⚠️ **_To be merged once the Packagist edit has been made._** ⚠️

This reverts commit f6dc841 and updates the information in the changelog for the 3.8.0 release.

**Users who already changed the package name in _their_ `composer.json` dependencies, should switch back to the original package name.**

Refs:
* See [the conversation from this comment down](squizlabs/PHP_CodeSniffer#3932 (comment)).

Closes 113, 114
@jrfnl
Copy link
Member Author

jrfnl commented Dec 6, 2023

This PR has been marked as a "breaking Change", though it really is an "unbreaking change".
The few dozen repos which already switched to the new name should switch back to the old name.

In the mean time, everything has been lined up, it is only as this is a "protected" package that the change on Packagist hasn't been made yet as it needs to be done by a Packagist admin.

With that in mind, I'm going to merge this now anyway.

@jrfnl jrfnl merged commit 8faa7c3 into master Dec 6, 2023
63 checks passed
@jrfnl jrfnl deleted the feature/composer-revert-name-change branch December 6, 2023 23:27
jrfnl referenced this pull request in stayforlong/twigStay Dec 7, 2023
jrfnl referenced this pull request in JamesRezo/spip-coding-standards Dec 7, 2023
jrfnl referenced this pull request in BeAPI/simple-punctual-translation Dec 7, 2023
jrfnl referenced this pull request in devdot/monolog-parser Dec 7, 2023
jrfnl referenced this pull request in devdot/log-artisan Dec 7, 2023
@stronk7
Copy link
Contributor

stronk7 commented Dec 8, 2023

Out of curiosity... will the phpcsstandards/php_codesniffer package be removed in the future... or will the duality exist forever?

Sorry if it has been decided elsewhere, I may have missed it (though i'm trying to follow the relevant discussions).

Ciao :-)

PS: Edited, wrong link!

@jrfnl
Copy link
Member Author

jrfnl commented Dec 8, 2023

@stronk7 I will likely mark it as abandoned and point to the original package name as its replacement. Not sure it can even be removed.

jrfnl referenced this pull request in forrest79/phpcs-ignores Dec 10, 2023
jrfnl added a commit to WordPress/WordPress-Coding-Standards that referenced this pull request Dec 10, 2023
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package [has been reverted](PHPCSStandards/PHP_CodeSniffer#135).
@jrfnl jrfnl mentioned this pull request Dec 10, 2023
11 tasks
jrfnl referenced this pull request in DannyvdSluijs/exact-online-meta-data-tool Dec 12, 2023
* refactor: Require PHP 8.0; Bump all dependencies; Update workflow for PHP 8 requirement including newer versions PHP

* refactor: Update code to PHP 8.0 using rector; Upgrade progressbar to show current url

* refactor: Improving for PHP 8.0 support

* fix: Add missing entry in known endpoints to avoid losing ProjectProjectProgressReports
jrfnl referenced this pull request in code-distortion/fluent-dotenv Dec 23, 2023
Improved Github Actions test coverage
Removed momentary usage of putenv() during the .env load process when using vlucas/phpdotenv
Removed momentary usage of putenv() during the .env load process when using symfony/dotenv >= 5.1.0
Improved the Adapter code that uses vlucas/phpdotenv and symfony/dotenv
jrfnl referenced this pull request in netresearch/t3x-nr-textdb Dec 23, 2023
jrfnl referenced this pull request in michaelbaril/sqlout Dec 31, 2023
jrfnl referenced this pull request in chillerlan/php-settings-container Jan 6, 2024
AngryDumbledore added a commit to AngryDumbledore/phar that referenced this pull request May 29, 2024
Follow up on 143

In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package [has been reverted](PHPCSStandards/PHP_CodeSniffer#135).

Sorry for the confusion and thank you for understanding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants