Squiz/VariableComment: allow union and intersection types to be detected #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Focus: Comments/Docblocks
Standard: Squiz
Status: triage
labels
fcool
force-pushed
the
bugfix/union-types-variable-comment
branch
2 times, most recently
from
2eeb0f2
to
6b48b12
Compare
|
I do not understand why the tests are failing - they are not locally - and I did not change anything regarding to alignment... so I would not expect any changes there... |
fredden
reviewed
Jan 2, 2024
fcool
force-pushed
the
bugfix/union-types-variable-comment
branch
from
6b48b12
to
369ec5b
Compare
If one uses a union type for an object property, the doc-type-hint could not be related to the variable type. Fixed now. Includes unit test.
fcool
force-pushed
the
bugfix/union-types-variable-comment
branch
from
369ec5b
to
ebb6b37
Compare
fredden
reviewed
Jan 2, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one uses a union type for an object property, the doc-type-hint could not be related to the variable type.
Fixed now.
Includes unit test.
This is a continuation of #3757
Closes #178
Closes squizlabs/PHP_CodeSniffer#3757