Add community-cc-list.md file
#228
Conversation
jrfnl
force-pushed
the
feature/227-community-cc-list
branch
2 times, most recently
from
c40275e
to
e904e45
Compare
|
@jrfnl please add me in as well, thanks ❤️ |
.github/community-cc-list.md
Outdated
| For more context, see https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/227 | ||
| --> | ||
|
|
||
| /cc @kukulich, @greg0ire @Ocramius |
There was a problem hiding this comment.
Putting each user on a separate line will make code reviews easier in future.
Is there intentionally a difference between a comma and a space for separating usernames?
There was a problem hiding this comment.
The comma/space was a typo from my side which I've corrected.
As for putting each handle on a separate line - good point.
I'm a bit in doubt though on whether to do that as yes, it will make a PR diff easier to review, but on the other hand, it will make using the list more cumbersome as I'd normally want to copy/paste this as a one-liner in the ticket text and having each user on a separate line would require editing the paste to remove the new lines.
There was a problem hiding this comment.
I think just using space with the list would look a bit more like the codeowners file, so I'd probably opt to follow that convention as well.
jrfnl
force-pushed
the
feature/227-community-cc-list
branch
from
e904e45
to
033dad0
Compare
|
@michalbundyra Added! |
jrfnl
force-pushed
the
feature/227-community-cc-list
branch
from
033dad0
to
4d4f2a4
Compare
jrfnl
force-pushed
the
feature/227-community-cc-list
branch
from
4d4f2a4
to
680f7c3
Compare
jrfnl
force-pushed
the
feature/227-community-cc-list
branch
from
680f7c3
to
65afb16
Compare
This adds the initial cc list file. Fixes 227
jrfnl
force-pushed
the
feature/227-community-cc-list
branch
from
65afb16
to
73e959c
Compare
Description
This adds the initial wider PHP_CodeSniffer community cc list file as proposed in #227.
Suggested changelog entry
N/A
Related issues/external references
Closes #227