Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft deprecate all sniffs which are to be removed in PHPCS 4.0 #276

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jan 15, 2024

Description

The deprecation of these sniffs was previously already announced in:

This commit soft deprecates these sniffs with a @deprecated annotation. This will get a mention in the changelog.

Hard deprecation will follow in a future 3.x minor as per #188.

Suggested changelog entry

Deprecated

  • #2448 Support for scanning JavaScript and CSS files.
    • This also means that all sniffs which are only aimed at JavaScript or CSS files are now deprecated.
    • The Javascript and CSS Tokenizers, all Javascript and CSS specific sniffs, and support for JS and CSS in select sniffs which support multiple file types, will be removed in version 4.0.0.
  • #2471 The MySource standard and all sniffs in it.
    • The MySource standard and all sniffs in it will be removed in version 4.0.0.

The deprecation of these sniffs was previously already announced in:
* CSS/JS specific sniffs: squizlabs/PHP_CodeSniffer#2448
* MySource standard: squizlabs/PHP_CodeSniffer#2471

This commit _soft_ deprecates these sniffs with a `@deprecated` annotation. This will get a mention in the changelog.

Hard deprecation will follow in a future 3.x minor as per 188.
@jrfnl jrfnl force-pushed the feature/soft-deprecate-sniffs-to-be-removed-in-4.0 branch from 6b0ba5d to 0f18ec6 Compare January 19, 2024 04:54
@jrfnl
Copy link
Member Author

jrfnl commented Jan 19, 2024

Rebased without changes before merge.

@jrfnl jrfnl merged commit ccbbd71 into master Jan 19, 2024
44 checks passed
@jrfnl jrfnl deleted the feature/soft-deprecate-sniffs-to-be-removed-in-4.0 branch January 19, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant