Squiz/ForLoopDeclaration: bug fix - prevent sniff erroring out #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
rodrigoprimo
reviewed
Apr 2, 2024
src/Standards/Squiz/Sniffs/ControlStructures/ForLoopDeclarationSniff.php
Outdated
Show resolved
Hide resolved
jrfnl
force-pushed
the
feature/squiz-forloopdeclaration-prevent-php-notice
branch
from
1fbd83d
to
afc3365
Compare
rodrigoprimo
approved these changes
Apr 2, 2024
jrfnl
force-pushed
the
feature/squiz-forloopdeclaration-prevent-php-notice
branch
from
afc3365
to
674701a
Compare
|
Rebased without changes. Merging once the build passes. |
|
The build failure is unrelated to this PR. PR #436 should fix this. I will rebase again once that one has been merged. |
... in anticipation of adding addition test case files.
... on an _"Undefined array key "parenthesis_closer" "_ notice during live coding. Includes unit test.
jrfnl
force-pushed
the
feature/squiz-forloopdeclaration-prevent-php-notice
branch
from
674701a
to
9634005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Squiz/ForLoopDeclaration: rename test case file
... in anticipation of adding addition test case files.
Squiz/ForLoopDeclaration: move parse error test to its own file
Squiz/ForLoopDeclaration: bug fix - prevent sniff erroring out
... on an "Undefined array key "parenthesis_closer" " notice during live coding.
Includes unit test.
Suggested changelog entry
Squiz.ControlStructures.ForLoopDeclaration: prevent a potential "undefined array key" notice during live coding