Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for --sniffs and --exclude options #474

Merged
merged 27 commits into from
May 14, 2024
Merged

Increase test coverage for --sniffs and --exclude options #474

merged 27 commits into from
May 14, 2024

Commits on Apr 30, 2024

  1. Increase test coverage for --sniffs and --exclude

    @fredden
    fredden committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6bba777 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Merge remote-tracking branch 'upstream/master' into feature/tests/con… 

    …fig.sniffs-exclude
    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    46f27de View commit details
    Browse the repository at this point in the history

  2. Fix tyop

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    2829da7 View commit details
    Browse the repository at this point in the history

  3. Use capital letters in comments

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    61c7bf9 View commit details
    Browse the repository at this point in the history

  4. Quote fixed strings to avoid confustion with words

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    c73d0b3 View commit details
    Browse the repository at this point in the history

  5. Add full-stops

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    8e2603f View commit details
    Browse the repository at this point in the history

  6. Rename variable

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3391c09 View commit details
    Browse the repository at this point in the history

  7. Sort 'use' statements

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    f14581f View commit details
    Browse the repository at this point in the history

  8. Unwrap foreach; reduce test cases

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    7ee42d1 View commit details
    Browse the repository at this point in the history

  9. Name tests

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    13edab3 View commit details
    Browse the repository at this point in the history

  10. Test an empty string

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    bd314c1 View commit details
    Browse the repository at this point in the history

  11. Rename testscase

    @fredden
    fredden committed May 5, 2024
    Configuration menu
    Copy the full SHA
    1ffe83a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Add another test case

    @fredden
    fredden committed May 6, 2024
    Configuration menu
    Copy the full SHA
    db76be8 View commit details
    Browse the repository at this point in the history

  2. Correct indentation

    @fredden
    fredden committed May 6, 2024
    Configuration menu
    Copy the full SHA
    389f112 View commit details
    Browse the repository at this point in the history

  3. Mark test as not-risky

    @fredden
    fredden committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bd249fb View commit details
    Browse the repository at this point in the history

  4. Use more specific return type shape in comment

    @fredden
    fredden committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e92830d View commit details
    Browse the repository at this point in the history

  5. Assert configuration value is set on success

    @fredden
    fredden committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b6df259 View commit details
    Browse the repository at this point in the history

  6. Add test case for setting multiple times

    @fredden
    fredden committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b18272d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Rename class again 

    Now that we have tests asserting the result of these arguments and not just
validation of their input.
    @fredden
    fredden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6400c61 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Clarify shape of return array 

    Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
    @fredden @jrfnl
    fredden and jrfnl committed May 13, 2024
    Configuration menu
    Copy the full SHA
    35d8a65 View commit details
    Browse the repository at this point in the history

  2. Clarify shape of return array 

    Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
    @fredden @jrfnl
    fredden and jrfnl committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f7aa3ef View commit details
    Browse the repository at this point in the history

  3. Clarify shape of return array 

    Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
    @fredden @jrfnl
    fredden and jrfnl committed May 13, 2024
    Configuration menu
    Copy the full SHA
    fd5b8c7 View commit details
    Browse the repository at this point in the history

  4. Correct comment 

    Fixes copy/paste error

Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
    @fredden @jrfnl
    fredden and jrfnl committed May 13, 2024
    Configuration menu
    Copy the full SHA
    801aefa View commit details
    Browse the repository at this point in the history

  5. Set 'position' argument

    @fredden
    fredden committed May 13, 2024
    Configuration menu
    Copy the full SHA
    81bea03 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Avoid using internal method

    @fredden
    fredden committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9d964ee View commit details
    Browse the repository at this point in the history

  2. Mark internal method as internal

    @fredden
    fredden committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a0b31d9 View commit details
    Browse the repository at this point in the history

  3. Revert "Mark internal method as internal" 

    This reverts commit a0b31d9.
    @fredden
    fredden committed May 14, 2024
    Configuration menu
    Copy the full SHA
    70358b0 View commit details
    Browse the repository at this point in the history