Tests/Tokenizer: reorganize #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the tests directly related to the `Tokenizer\PHP` class into a `PHP` subdirectory. Move the tests directly related to the `Tokenizer\Tokenizer` class into a `Tokenizer` subdirectory. As there are five (soon three) Tokenizer classes, having the tests for each class in their own subdirectory makes it more straight forward to see what code is covered by tests.
... into two test classes, one targetting the `Tokenizer\PHP` class, one targetting the `Tokenizer\Tokenizer` class. While this does mean there is now some duplication between these test classes, I don't think that's problematic. It also allows for these tests to diverge based on the specific test needs for each of these classes.
... into two test classes, one targetting the `Tokenizer\PHP` class, one targetting the `Tokenizer\Tokenizer` class. While this does mean there is now some duplication between these test classes, I don't think that's problematic. It also allows for these tests to diverge based on the specific test needs for each of the classes under test.
... into two test classes, one targetting the `Tokenizer\PHP` class, one targetting the `Tokenizer\Tokenizer` class. While this does mean there is now some duplication between these test classes, I don't think that's problematic. It also allows for these tests to diverge based on the specific test needs for each of the classes under test.
... into two test classes, one targetting the `Tokenizer\PHP` class, one targetting the `Tokenizer\Tokenizer` class. While this does mean there is now some duplication between these test classes, I don't think that's problematic. It also allows for these tests to diverge based on the specific test needs for each of the classes under test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests/Tokenizer: move tests
Move the tests directly related to the
Tokenizer\PHPclass into aPHPsubdirectory.Move the tests directly related to the
Tokenizer\Tokenizerclass into aTokenizersubdirectory.As there are five (soon three) Tokenizer classes, having the tests for each class in their own subdirectory makes it more straight forward to see what code is covered by tests.
Tests/Tokenizer/ArrayKeywordTest: split the test class
Tests/Tokenizer/DefaultKeywordTest: split the test class
Tests/Tokenizer/DNFTypesTest: split the test class
Tests/Tokenizer/EnumCaseTest: split the test class
... into two test classes, one targetting the
Tokenizer\PHPclass, one targetting theTokenizer\Tokenizerclass.While this does mean there is now some duplication between these test classes, I don't think that's problematic.
It also allows for these tests to diverge based on the specific test needs for each of the classes under test.
Suggested changelog entry
N/A