Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: update merge conflict check workflow #519

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 5, 2024

Description

The mschilde/auto-label-merge-conflicts action runner is not actively maintained and is currently failing due to an unhandled deprecation notice. Example

I've evaluated the action runners available for this kind of thing and am proposing to switch to the eps1lon/actions-label-merge-conflict action runner, which should be a one-on-one replacement for the currently used functionality.

Additionally, that action has an option to post a comment when a conflict is detected as well as when the conflict has been resolved. While not currently used, this feature might be useful in the future.

Note: unfortunately, I won't be able to test the change until merged into the master branch, so this may need further tweaks once merged.

Refs:

Suggested changelog entry

N/A

The `mschilde/auto-label-merge-conflicts` action runner is not actively maintained and is currently failing due to an unhandled deprecation notice.
[Example](https://github.com/PHPCSStandards/PHP_CodeSniffer/actions/runs/9380398878/job/25827454084)

I've evaluated the action runners available for this kind of thing and am proposing to switch to the `eps1lon/actions-label-merge-conflict` action runner, which should be a one-on-one replacement for the currently used functionality.

Additionally, that action has an option to post a comment when a conflict is detected as well as when the conflict has been resolved. While not currently used, this feature might be useful in the future.

Note: unfortunately, I won't be able to test the change until merged into the `master` branch, so this may need further tweaks once merged.

Refs:
* https://github.com/marketplace?query=label+merge+conflicts
* https://github.com/mschilde/auto-label-merge-conflicts
* https://github.com/eps1lon/actions-label-merge-conflict
@jrfnl jrfnl added this to the 3.10.x Next milestone Jun 5, 2024
@jrfnl jrfnl merged commit a6b0baf into master Jun 5, 2024
49 of 50 checks passed
@jrfnl jrfnl deleted the feature/ghaction-fix-merge-conflict-status-workflow branch June 5, 2024 09:26
@jrfnl
Copy link
Member Author

jrfnl commented Jun 5, 2024

Looks like it's working as intended: https://github.com/PHPCSStandards/PHP_CodeSniffer/actions/runs/9381613073/job/25831215405 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant