-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common::getSniffCode(): add tests, more defensive coding and minor simplification #524
Open
jrfnl
wants to merge
5
commits into
master
Choose a base branch
from
feature/common-add-tests-and-simplify
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial set of tests for the `Common::getSniffCode()` method. Related to 146 Related to [review comment in PR 446](#446 (comment)).
Previously, if an empty string was passed, the `Common::getSniffCode()` method would return `..`, which is just confusing (and incorrect). This commit changes the behaviour to throw an `InvalidArgumentException` instead. Includes making a potentially superfluous function call to the method conditionally (as it could hit the new exception). Includes test.
Previously, if an invalid (incomplete) class name was passed, the `Common::getSniffCode()` method would return a garbled name, like `.Qualified.C`, which is just confusing. This commit changes the behaviour to throw an `InvalidArgumentException` instead. Includes test.
Previously, if an invalid class name was passed, which didn't end on `Sniff` or `UnitTest`, the `Common::getSniffCode()` method would return a garbled name, like `Fully.Qualified.C`, which is just confusing. This commit changes the behaviour to throw an `InvalidArgumentException` instead. Includes test.
* Remove the use of `array_pop()` in favour of directly referencing the required "parts" by their index in the array. * Remove the unused `$sniffDir` variable. * Remove the unnecessary `$code` variable. Related to [review comment in PR 446](#446 (comment)).
7 tasks
rodrigoprimo
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fredden
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Common::getSniffCode(): add tests
Add initial set of tests for the
Common::getSniffCode()
method.Related to #146
Related to review comment in PR 446.
Common::getSniffCode(): throw exception on invalid input [1]
Previously, if an empty string was passed, the
Common::getSniffCode()
method would return..
, which is just confusing.This commit changes the behaviour to throw an
InvalidArgumentException
instead.Includes making a potentially superfluous function call to the method conditionally (as it could hit the new exception).
Includes test.
Common::getSniffCode(): throw exception on invalid input [2a]
Previously, if an invalid (incomplete) class name was passed, the
Common::getSniffCode()
method would return a garbled name, like.Qualified.C
, which is just confusing.This commit changes the behaviour to throw an
InvalidArgumentException
instead.Includes test.
Common::getSniffCode(): throw exception on invalid input [2b]
Previously, if an invalid class name was passed, which didn't end on
Sniff
orUnitTest
, theCommon::getSniffCode()
method would return a garbled name, likeFully.Qualified.C
, which is just confusing.This commit changes the behaviour to throw an
InvalidArgumentException
instead.Includes test.
Common::getSniffCode(): minor simplification
array_pop()
in favour of directly referencing the required "parts" by their index in the array.$sniffDir
variable.$code
variable.Related to review comment in PR 446.
Suggested changelog entry
The
Common::getSniffCode()
method will now throw anInvalidArgumentException
exception if an invalid$sniffClass
is passed.