PSR1/SideEffects: improve recognition of disable/enable annotations #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/3386-psr1-sideffects-allow-for-ignore-with-errorcode
branch
from
ac183ed
to
e8cda77
Compare
jrfnl
force-pushed
the
feature/3386-psr1-sideffects-allow-for-ignore-with-errorcode
branch
from
e8cda77
to
7552c17
Compare
As it was, the sniff would respect PHPCS disable annotations, but only when either unqualified or qualified up to a sniff name. It would not respect a disable annotation using a sniffname with errorcode, i.e. `PSR1.Files.SideEffects.FoundWithSymbols`. While the `FoundWithSymbols` errorcode is the only error code for this sniff and using `// phpcs:disable PSR1.Files.SideEffects.FoundWithSymbols` is effectively the same as using `// phpcs:disable PSR1.Files.SideEffects`, I do believe end-users should not need to be aware of whether or not a sniff has multiple error codes when using disable annotations. This updates the sniff to also respect disable annotations which include the error code. Includes unit test. Fixes 3386
jrfnl
force-pushed
the
feature/3386-psr1-sideffects-allow-for-ignore-with-errorcode
branch
from
7552c17
to
5df13b3
Compare
jrfnl
deleted the
feature/3386-psr1-sideffects-allow-for-ignore-with-errorcode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recreation of upstream PR squizlabs/PHP_CodeSniffer#3772:
Suggested changelog entry
PSR1/SideEffects: improved recognition of disable/enable annotations