Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace http with https #206

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

SplotyCode
Copy link
Contributor

Proposed Changes

Related Issues
Code scans mark it as insecure. Here it really does not matter as the side upgrades to https it is still good practise

@jrfnl
Copy link
Member

jrfnl commented Aug 19, 2023

@Potherca As the plugin is no longer directly associated with DealerDirect, I'm thinking we may as well remove the homepage key from the composer.json file. What do you think ?

@jrfnl jrfnl added this to the 1.x Next Release milestone Aug 19, 2023
@Potherca
Copy link
Member

I'd say either point it to the repo https://github.com/PHPCSStandards/composer-installer or remove it.
Either one is fine by me.

@jrfnl
Copy link
Member

jrfnl commented Aug 19, 2023

@Potherca As the composer.json file already contains a link to the repo in support -> source, I don't think homepage linking to the repo has any added benefit.

@SplotyCode Thanks for the PR, would you mind removing the homepage key instead ?

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those updates @SplotyCode ! All looks good to me now.

@jrfnl
Copy link
Member

jrfnl commented Sep 17, 2023

@Potherca Could you please have another look & merge if you're also okay with the changes as they are now ?

@Potherca Potherca merged commit c3ef4d3 into PHPCSStandards:main Sep 22, 2023
12 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants