GH Actions: fix the build #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds against PHP 5.4 on Windows are failing. The failure happens even before the test run at the "Composer install" step. These failures look to be unrelated to this package, but seem to be related to PHP 5.4 trying to make an unsecured connection to Packagist and this no longer being supported. There may be ways to work around this, but I haven't been able to find one other than downloading a new certificate bundle and using that (not tested). Considering PHP 5.4 is ancient, I'm proposing to just drop the test runs against PHP 5.4 in combination with Windows.
jrfnl
force-pushed
the
feature/ghactions-fix-build
branch
from
9f9b7d9
to
49c9f1b
Compare
|
To merge this PR, the branch protection needs to be updated to remove the two PHP 5.4/Windows builds from being required. |
Potherca
approved these changes
Dec 3, 2023
|
Is it possible to just admin-bypass the merge? That would negate the need to turn branch protection off-and on-again.
|
It is, but that would be counter-productive as we're removing those two builds, so they need to be removed from the branch protection as otherwise all future PRs will also need the admin-bypass as they are missing those two builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Builds against PHP 5.4 on Windows are failing. The failure happens even before the test run at the "Composer install" step.
These failures look to be unrelated to this package, but seem to be related to PHP 5.4 trying to make an unsecured connection to Packagist and this no longer being supported. There may be ways to work around this, but I haven't been able to find one other than downloading a new certificate bundle and using that (not tested).
Considering PHP 5.4 is ancient, I'm proposing to just drop the test runs against PHP 5.4 in combination with Windows.