Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sniff detecting $this in closure #24

Closed
bantu opened this issue Jan 13, 2014 · 2 comments
Closed

Add sniff detecting $this in closure #24

bantu opened this issue Jan 13, 2014 · 2 comments
Labels
enhancement
Milestone
7.1.4

Comments

@bantu
Copy link

bantu commented Jan 13, 2014

It would be useful to have a sniff detecting $this in closures for PHP 5.3 compatibility.
@kevinlangleyjr
Copy link

It should be checking for self in the same context as well.

@wimg
Copy link
Member

wimg commented Jun 29, 2016

The problem is that as of PHP 5.4, $this can be used in anonymous functions. So it might seem a bit silly to add a test for that now.

@wimg wimg closed this as completed Jun 29, 2016
@jrfnl jrfnl mentioned this issue Apr 3, 2017
Merged
@jrfnl jrfnl added this to the 7.1.4 milestone May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.1.4
Development

No branches or pull requests
4 participants
@bantu @wimg @jrfnl @kevinlangleyjr