False positive on a prefixed function

[dingo-d]

Theme sniffer plugin uses PHPCompatiblity to check if the theme is compatible with certain versions of php.

We got an issue where a custom made function that's called family_grows_entry_posted_on_setup() triggers error

Extension 'fam' is removed since PHP 5.1

The family part gives a false positive.

Can this be fixed?

Thanks.

[kick-the-bucket]

Sniff should probably differentiate extensions which use an underscore (_) after their name in functions and those which don't. Not sure about fam though - never heard of it before...

…

On Feb 13, 2018 09:35, "Denis Žoljom" ***@***.***> wrote: Theme sniffer <https://github.com/WPTRT/theme-sniffer> plugin uses PHPCompatiblity to check if the theme is compatible with certain versions of php. We got an issue where a custom made function that's called family_grows_entry_posted_on_setup() triggers error Extension 'fam' is removed since PHP 5.1 The family part gives a false positive. Can this be fixed? Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#582>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvbtEZHfrIQM8-Hdy1EkEqpI5-DgzhWks5tUTszgaJpZM4SDU-L> .

[jrfnl]

Related #207, #509

I am aware that the Deprecated/Removed Extensions sniff is a bit overzealous at times.
I've done some work on this previously (unfinished) and will see if I can get back to that soon.

[Wirone]

Just FYI: we got similar false-positives for recode extension because we had private static method called recodeSomethingSomethingSomething (not actual name of course 😆).

PHPCompatibility.Extensions.RemovedExtensions should take into consideration if called function actually is a function or method. Since recode extension provided only 3 functions, there's no need to process methods.

[jrfnl]

@Wirone FYI: the sniff will be removed in PHPCompatibility 10.0.0, in favour of more detailed checks. See #180.