Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xml doc] RemovedPCREModifiers #1295

Merged
merged 4 commits into from
Mar 28, 2023
Merged

[xml doc] RemovedPCREModifiers #1295

merged 4 commits into from
Mar 28, 2023

Conversation

afilina
Copy link
Contributor

@afilina afilina commented Aug 16, 2021 •
edited by jrfnl

I messed up a rebase due to inattention. This replaces #1272.

Related to #1285

@afilina
Copy link
Contributor Author

afilina commented Aug 16, 2021

@jrfnl I rebased the code onto the recent develop so that it would account for your fixes to the PHP 8.1 lint. The 8.1 tests are still failing, but that's unrelated to my PR. It looks like the develop branch might be a WIP.

@jrfnl
Copy link
Member

jrfnl commented Aug 16, 2021

@jrfnl I rebased the code onto the recent develop so that it would account for your fixes to the PHP 8.1 lint. The 8.1 tests are still failing, but that's unrelated to my PR. It looks like the develop branch might be a WIP.

Yes! The linting fixes have been merged over the weekend and released, so the PHP 8.1 lint is now passing 🎉

As for the tests failing on PHP 8.1 - PHPCS itself still needs to be updated for the tokenizer changes in PHP 8.1 (and also still needs to merge some other PHP 8.1 related PRs), so this is as expected and outside our control.

@afilina
Copy link
Contributor Author

afilina commented Aug 17, 2021

@jrfnl Those issues are already fixed and pending PR merges on PHP_CodeSniffer.

  1. I installed PHPCompatibility locally.
  2. I installed PHP_CodeSniffer's dev-master.
  3. I applied PRs
  1. I ran PHPCompatibility tests using PHP 8.1.0beta2
  2. Got zero failures (there were failures before the PR patches).

Once those PRs are merged upstream, the CI here should turn green.

@jrfnl jrfnl mentioned this pull request Feb 27, 2022
Open
@jrfnl jrfnl added this to the 10.0.0 milestone Mar 27, 2023
afilina and others added 4 commits March 27, 2023 23:39
@afilina @jrfnl
Create extended XML docs following the same format as the phpcs project
ca72568
@afilina @jrfnl
Rename doc file
b2cd72d
@afilina @jrfnl
Fix extended doc: title, code width, opening tag
dfee66b
@jrfnl
Docs / ParameterValues/RemovedPCREModifiers: various tweaks
94244ed 
* Add proper XML header.
    Note: this is something which only recently became an option as there previously was no schema available.
* Style: have `CDATA` tags on their own lines.
    This makes the XML code style consistent with currently existing XML docs.
* Expand the issue description a little.
* Use `Cross-version compatible` and `PHP </> #.#` style prefixes in the code samples.
    This improves consistency with the other XML docs and makes the code samples more descriptive in the context of PHPCompatibility.
* Add `<em>` tags to the code samples to allow for highlighting the specific issue the sniff is looking for.
@jrfnl
Copy link
Member

jrfnl commented Mar 27, 2023

Rebased the PR and updated the document (with permission from @afilina). Will merge this one once the build passes.

@jrfnl jrfnl merged commit b06c4e3 into PHPCompatibility:develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afilina @jrfnl