Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of apparent bugs and minor clean-up. #138

Merged
merged 3 commits into from
Aug 3, 2016
Merged

Fix a number of apparent bugs and minor clean-up. #138

merged 3 commits into from
Aug 3, 2016

Commits on Aug 3, 2016

  1. Fix a number of apparent bugs and minor clean-up. 

    Typical issues found & handled:
* Returning `false` from the `process()` method. This is wrong. If the process method returns something it will be interpreted as an integer stack position to continue checking from, so returning false could lead to race conditions.
* Variables which are set and subsequently never used.
* Strict(er) checking of variables before/when using them
* Function calls within loops
* Minor documentation inconsistencies
    @jrfnl
    jrfnl committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    c475e94 View commit details
    Browse the repository at this point in the history

  2. Fix persistent typo

    @jrfnl
    jrfnl committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    50eee20 View commit details
    Browse the repository at this point in the history

  3. Remove trailing spaces

    @jrfnl
    jrfnl committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    3215a35 View commit details
    Browse the repository at this point in the history