NewPCREModifiers: add support for named parameters #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add support for function calls using named parameters by implementing the new PHPCSUtils 1.0.0-alpha4 `PassedParameters::getParameterFromStack()` method.
2. Verified the parameter name used is in line with the name as per the PHP 8.0 release.
PHP itself renamed a lot of parameters in PHP 8.0. As named parameters did not exist before PHP 8.0, the parameter name as per PHP 8.0 (or above) is the only relevant name.
Name verification reference:
* `preg_filter`: https://3v4l.org/eJNZe
* `preg_grep`: https://3v4l.org/Am8aX
* `preg_match_all`: https://3v4l.org/IoIJQ
* `preg_match`: https://3v4l.org/TfVDB
* `preg_replace_callback_array`: https://3v4l.org/Hp8rI
* `preg_replace_callback`: https://3v4l.org/BHj7T
* `preg_replace`: https://3v4l.org/0lr5d
* `preg_split`: https://3v4l.org/jJMg0
Includes adding/adjusting the unit tests to include tests using named parameters.
jrfnl
added
enhancement
PR: quick merge
42 tasks
wimg
approved these changes
Oct 31, 2022
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PassedParameters::getParameterFromStack()method.Name verification reference:
preg_filter: https://3v4l.org/eJNZepreg_grep: https://3v4l.org/Am8aXpreg_match_all: https://3v4l.org/IoIJQpreg_match: https://3v4l.org/TfVDBpreg_replace_callback_array: https://3v4l.org/Hp8rIpreg_replace_callback: https://3v4l.org/BHj7Tpreg_replace: https://3v4l.org/0lr5dpreg_split: https://3v4l.org/jJMg0Includes adding/adjusting the unit tests to include tests using named parameters.
Related to #1239