✨ PHP 8.1: New PHPCompatibility.ParameterValues.NewHTMLEntitiesFlagsDefault sniff
#1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Default` sniff > htmlspecialchars(), htmlentities(), htmlspecialchars_decode(), > html_entitity_decode() and get_html_translation_table() now use > ENT_QUOTES | ENT_SUBSTITUTE rather than ENT_COMPAT by default. This means > that ' is escaped to ' while previously it was left alone. > Additionally, malformed UTF-8 will be replaced by a Unicode substitution > character, instead of resulting in an empty string. Refs: * https://github.com/php/php-src/blob/28a1a6be0873a109cb02ba32784bf046b87a02e4/UPGRADING#L149-L154 * php/php-src@50eca61 This new sniff will detect and flag use of these function without explicitly passing the `$flags` parameter when `testVersion` includes both PHP < 8.1 as well as PHP 8.1+. Note: the extra `ENT_HTML401` addition is a documentation-only change as the value of the constant is `0`, so has no effect on the bitwise value of the flag. Includes unit tests. Includes sniff documentation.
wimg
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
This new sniff will detect and flag use of these function without explicitly passing the
$flagsparameter whentestVersionincludes both PHP < 8.1 as well as PHP 8.1+.Note: the extra
ENT_HTML401addition is a documentation-only change as the value of the constant is0, so has no effect on the bitwise value of the flag.Includes unit tests.
Includes sniff documentation.
Related to #1299