PHP 8.0 | TypeDeclaration sniffs: examine properties declared in the constructor correctly #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructor Typed properties declared via a class constructor should also be examined by the `NewTypedProperties` sniff as the allowed types for properties are different than those for parameters. Includes: * Adding `T_FUNCTION` to the tokens to be examined. * Splitting the "type checking" logic off into its own method to allow for multiple properties declared in a constructor. Includes unit tests. Ref: https://wiki.php.net/rfc/constructor_promotion
Properties declared via a class constructor follow the property type rules, not the parameter type rules, so ignore them for this sniff. These will be examined in the `NewTypedProperties` sniff instead. Includes unit tests.
40 tasks
wimg
approved these changes
Dec 30, 2022
wimg
deleted the
php-8.0/newtypedproperties-newparamtype-support-constructor-property-promotion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 | NewTypedProperties: examine properties declared in the constructor
Typed properties declared via a class constructor should also be examined by the
NewTypedPropertiessniff as the allowed types for properties are different than those for parameters.Includes:
T_FUNCTIONto the tokens to be examined.Includes unit tests.
Ref: https://wiki.php.net/rfc/constructor_promotion
PHP 8.0 | NewParamTypeDeclarations: ignore promoted properties
Properties declared via a class constructor follow the property type rules, not the parameter type rules, so ignore them for this sniff. These will be examined in the
NewTypedPropertiessniff instead.Includes unit tests.
Related to #809