✨ New PHPCompatibility.Classes.ForbiddenExtendingFinalClass sniff
#1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/new-forbiddenextendingfinalclass-sniff
branch
from
640e3b2
to
ce0ecf5
Compare
jrfnl
force-pushed
the
feature/new-forbiddenextendingfinalclass-sniff
branch
from
ce0ecf5
to
48a64ac
Compare
jrfnl
force-pushed
the
feature/new-forbiddenextendingfinalclass-sniff
branch
from
48a64ac
to
52b6452
Compare
> Implemented FR #78638 (__PHP_Incomplete_Class should be final) Refs: * https://github.com/php/php-src/blob/0e45ed772df304c58f151d75d75f4ab5d9192c5b/NEWS#L1526 * php/php-src@b418f33 To address this change, I'm introducing a new array based sniff which allows for more classes to be added if/when more native PHP classes would become `final`. Includes unit tests. Includes XML docs.
jrfnl
force-pushed
the
feature/new-forbiddenextendingfinalclass-sniff
branch
from
52b6452
to
e25f3d5
Compare
wimg
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the PHP 8.0 changelogs:
Refs:
To address this change, I'm introducing a new array based sniff which allows for more classes to be added if/when more native PHP classes would become
final.Includes unit tests.