PHP 8.0 | Keywords/NewKeywords: detect the new match keyword (RFC)
#1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.0 introduced match expressions. What with originally still supporting a wide range of PHPCS versions, detection of match expressions would need a lot of custom logic, so this would get a separate sniff (which I had as WIP locally). However, now support for PHPCS < 3.7.1 has been dropped, detection of the keyword can be handled by the `NewKeywords` sniff. Includes the tests I had originally set up for the separate sniff. Refs: * https://wiki.php.net/rfc/match_expression_v2 * php/php-src#5371 * php/php-src@9fa1d13 Related to 809
jrfnl
added
enhancement
PR: quick merge
40 tasks
wimg
approved these changes
Aug 4, 2023
github-actions
bot
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 introduced match expressions.
What with originally still supporting a wide range of PHPCS versions, detection of match expressions would need a lot of custom logic, so this would get a separate sniff (which I had as WIP locally).
However, now support for PHPCS < 3.7.1 has been dropped, detection of the keyword can be handled by the
NewKeywordssniff. Includes the tests I had originally set up for the separate sniff.Refs:
Related to #809