Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sniff for various integer types. #160

Merged
merged 1 commit into from Aug 13, 2016

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 13, 2016

Checks for:

  • binary integers which were introduced in PHP 5.4
  • invalid binary integers
  • invalid octal integers which were truncated prior to PHP 7 (warning) and give a parse error in 7 (error).
  • hexadecimal numeric strings for which the type juggling behaviour and recognition as numeric was inconsistent prior to PHP 7 (warning) and are no longer treated as numeric in PHP 7+(error).

Includes unit tests.

Closes #55

Checks for:
* binary integers which were introduced in PHP 5.4
* invalid binary integers
* invalid octal integers which were truncated prior to PHP 7 (warning) and give a parse error in 7 (error).
* hexadecimal numeric strings for which the type juggling behaviour and recognition as numeric was inconsistent prior to PHP 7 (warning) and are no longer treated as numeric in PHP 7+(error).

Includes unit tests.

Closes PHPCompatibility#55
@wimg wimg merged commit 91066a8 into PHPCompatibility:master Aug 13, 2016
@jrfnl jrfnl deleted the feature/binary-int-sniff branch August 13, 2016 14:10
@jrfnl jrfnl added this to the 7.0.3 milestone Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants