PHP 8.3 | ✨ New PHPCompatibility.ParameterValues.RemovedLdapConnectSignatures
sniff (RFC)
#1620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
This adds a new sniff to detect the above.
Note:
Normally this kind of change would be handled via the
RemovedFunctionParameters
sniff, but this function has three distinct signatures and the signatures are being deprecated in reverse order, i.e. the 2-param signature is being deprecated in PHP 8.3, while the 3+ param signature is being deprecated in PHP 8.4. For that reason, theRemovedFunctionParameters
sniff is not suitable to handle this.Also note that, while the three+ param signature is still supported, passing a separate
$host
and$port
is also deprecated for that signature. Instead a$uri
should be passed and$port
should be set tonull
. The sniff does take this into account and handles this via a separate error code.Includes tests and documentation.
Related to #1589