Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ForbiddenEmptyListAssignment sniff (code review). #166

Commits on Aug 14, 2016

  1. Improve ForbiddenEmptyListAssignment sniff (code review).

    * Trigger error when there are only comments between the parenthesis.
    * Trigger error when there are empty parenthesis between the list parenthesis.
    * Don't trigger error for unfinished code when review is used during live coding (in an editor).
    * Slightly simplify the code.
    * Remove unnecessary `sprintf()`.
    
    Includes unit tests demonstrating the issue with the comments.
    Includes some extra unit tests for valid list assignments.
    
    As there are now more test cases, refactored the unit tests to use data providers as well.
    jrfnl committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    75b8212 View commit details
    Browse the repository at this point in the history