Classes/RemovedClasses: detect removed classes in PHP 8.2 DNF types #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added
enhancement
PR: quick merge
This updates the sniff to also detect removed classes when used in DNF types. Includes unit tests.
jrfnl
force-pushed
the
php-8.2/removed-classes-detect-classes-in-dnf-types
branch
from
432d8ea
to
46b70ba
Compare
|
Rebased without changes now #1714 has been merged. Marking as ready. |
wimg
approved these changes
Jul 13, 2024
github-actions
bot
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the sniff to also detect removed classes when used in DNF types.
Includes unit tests.
Related to #1348
Note: this PR has been opened as draft as it depends on PR #1714 due to the need for PHPCS 3.10.0 (and will need a rebase once that PR has been merged). Having said that, the PR in itself is ready.