Make sure all test classes have one or more consistent group annotations #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons. - Every class has a `@group` annotation mirroring the name of the sniff being tested. - Classes with tests covering related sniffs, have a secondary group annotation for the larger group, i.e. `InternalInterfaces` and `NewInterfaces`, both have their own group as well as a secondary `interfaces` group. - For utility function test classes, the group name is `utility`+ the name of the function. - Removed the `@group` annotations for single tests in sniff test files as having the annotation for the class will assign it to all tests in that class and that's how it was currently used anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@groupannotation allows for the running of groups of tests based on a command line/xml property being set.As the test suite is quite large, this allows for quicker/easier testing of a select group of changed tests/sniffs.
This PR covers:
@groupannotation mirroring the name of the sniff being tested.InternalInterfacesandNewInterfaces, both have their own group as well as a secondaryinterfacesgroup.utility+ the name of the function.@groupannotations for single tests in sniff test files as having the annotation for the class will assign it to all tests in that class and that's how it was currently used anyway.