Make the NewGroupUseDeclarationsSniff available in PHPCS < 2.6.0 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking to increase code coverage, this seemed like a quick fix to make. I've also tested it against various PHPCS versions and the version number previously used for exclusion/test skipping appears wrong. Turns out the `T_OPEN_USE_GROUP` token was only introduced into PHPCS in v2.6.0. Includes additional unit test cases to test for more differentiation in syntax. Removes test exclusion for this sniff on older PHPCS versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking to increase code coverage, this seemed like a quick fix to make.
I've also tested it against various PHPCS versions and the version number previously used for exclusion/test skipping appears wrong and the sniff was throwing notices about an undefined constant in some versions. Turns out the
T_OPEN_USE_GROUPtoken was only introduced into PHPCS in v2.6.0.Includes additional unit test cases to test for more differentiation in syntax.
Removes test exclusion for this sniff on older PHPCS versions.