Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test consistency: false positive tests #345

Merged
merged 3 commits into from Feb 25, 2017
Merged

Test consistency: false positive tests #345

merged 3 commits into from Feb 25, 2017

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Feb 20, 2017 •
edited

  • Make the function names for the false positive tests consistent
  • Make the function order for the false positive tests consistent - test files test for what the sniff is all about first, after that test against false positives. I.e. move some functions down.
  • Add some false positive tests for sniffs which didn't have any.

P.S.: this PR will be easiest to review by reviewing the commits individually.

@coveralls
Copy link

coveralls commented Feb 20, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 95.765% when pulling 8c5cc0c on jrfnl:feature/test-against-false-positives into 60a13ae on wimg:master.

@jrfnl
Tests: Add some tests against false positives for sniffs which didn't…
ccbaf5b 
… have them.
@jrfnl
Tests: Make the function names for tests against false positives more…
297cce4 
… intuitive & consistent.
@jrfnl
Tests: Consistent test order, first test the sniff, then test for `no…
04636e5 
…FalsePositives`.

Includes:
* Reworking of one such test to use a dataprovider.
* Extracting some tests to their own function (`const` keyword noFalsePositive tests in the NewKeywordsSniffTest)
@jrfnl jrfnl force-pushed the feature/test-against-false-positives branch from 8c5cc0c to 04636e5 Compare February 25, 2017 18:30
@jrfnl
Copy link
Member Author

jrfnl commented Feb 25, 2017

Rebased for merge conflicts.

@coveralls
Copy link

coveralls commented Feb 25, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 95.765% when pulling 04636e5 on jrfnl:feature/test-against-false-positives into cc8713f on wimg:master.

@wimg wimg merged commit 10d93fe into PHPCompatibility:master Feb 25, 2017
@jrfnl jrfnl deleted the feature/test-against-false-positives branch February 25, 2017 23:28
@jrfnl jrfnl added this to the 7.1.3 milestone May 2, 2017
@jrfnl jrfnl mentioned this pull request Mar 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chores/QA
Projects
None yet
Milestone
7.1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrfnl @coveralls @wimg