Add anonymous class support in the InternalInterfaces and NewInterfaces sniffs. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es sniffs. While there have no new interfaces been introduced since the introduction of anonymous classes, this will make the sniff forward compatible for when those are introduced. For InternalInterfaces, the change is already relevant. Includes unit tests. As there are now more tests, largely reworked the InternalInterfaces unit tests to data providers. In a similar vain, reworked the `testUnsupportedMethods` test in the `NewInterfaces` unit test file to use a data provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there have no new interfaces been introduced since the introduction of anonymous classes, this will make the sniff forward compatible for when those are introduced.
For InternalInterfaces, the change is already relevant.
Includes unit tests.
As there are now more tests, largely reworked the InternalInterfaces unit tests to data providers.
In a similar vain, reworked the
testUnsupportedMethodstest in theNewInterfacesunit test file to use a data provider.One of several PRs to fix #351