Minor refactor of the NewConstVisibility sniff.
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the new `isClassConstant()` utility method. * Bow out early if not testing for PHP < 7.1 (was originally done later as some "debug" checks were slated to go in and didn't) Includes additional unit tests.
wimg
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a review to see which sniffs would benefit from using the new
isClassProperty()andisClassConstant()methods as introduced in #391 and #393.isClassConstant()utility method as introduced in PHP 5.3: Add new sniff to detect heredoc initialization #391.Includes additional unit tests.