Fix the travis builds for changes in the travis infrastructure #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
jrfnl
force-pushed
the
feature/travis-play-nice
branch
from
7938348
to
0568024
Compare
Travis CI announced they are switching to Trusty as the default distro starting July 18th and of course, this is impacting our builds. See: https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming The net effect is that PHP 5.3 will only be available on `precise`, but they have also announced that they will remove that option starting September 2017, so I'm not sure what we can do from then on. For now, this should buy us some time. The change over to `trusty` apparently also means that `libxml2` is no longer available by default. This was breaking the build for the XML code style check jobs. By setting it as one of the addon packages we require, this should be fixed again. Last point I'm addressing here is PHP 5.4 in combination with PHPCS 1.x and low PHPCS 2.x versions. For completely unfathomable reasons, this build was not passing anymore with lots of unit test failures, even though it shouldn't really be affected by the above mentioned changes. Even so, moving that build to `precise` as well, fixes it.
jrfnl
force-pushed
the
feature/travis-play-nice
branch
from
0568024
to
87857c2
Compare
wimg
approved these changes
Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI announced they are switching to Trusty as the default distro starting July 18th and of course, this is straight away impacting our builds.
See: https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
This PR will need to be merged before the builds for the other open PRs will start passing again (after they are rebased if needed).
The net effect is that PHP 5.3 will only be available on
precise, but they have also announced that they will remove that option starting September 2017, so I'm not sure what we can do from then on.For now, this should buy us some time.
The change over to
trustyapparently also means thatlibxml2is no longer available by default.This was breaking the build for the XML code style check jobs. By setting it as one of the addon packages we require, this should be fixed again.
Last point I'm addressing here is PHP 5.4 in combination with PHPCS 1.x. For completely unfanthomable reasons, this build was not passing anymore with lots of unit test failures, even though it shouldn't really be affected by the above mentioned changes.
Even so, moving that build to
preciseas well, fixes it.