Travis/Build: validate the composer.json file #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the composer.json file on each build. Ref: https://getcomposer.org/doc/03-cli.md#validate Also updates the license identifier in the `composer.json` file. Notes: * This check has not been restricted to a specific PHP version as there may be different versions of Composer being run on different Travis PHP images, so validating the file once against each PHP/Composer combi should make sure the file is properly validated. * `--strict` checking is disabled with reason. As of Composer 1.6.0, the SPDX license identifiers v3.0 for GPL/LGPL/AGPL are supported and the old license identifiers are deprecated. So using the "new" license identifier would fail the validation for Composer < 1.6.0, using the old license idenfifier would fail the validation for Composer 1.6.0+. By ignoring warnings, this issue is bypassed. Refs: * https://github.com/composer/composer/releases/tag/1.6.0 * https://spdx.org/news/news/2018/01/license-list-30-released
wimg
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the composer.json file on each build.
Ref: https://getcomposer.org/doc/03-cli.md#validate
Also updates the license identifier in the
composer.jsonfile toLGPL-3.0-or-later(see more about this below).The license could also be limited to just LGPL 3.0 by using
LGPL-3.0-only.@wimg Let me know if that would be preferred.
Notes:
--strictchecking is disabled with reason. As of Composer 1.6.0, the SPDX license identifiers v3.0 for GPL/LGPL/AGPL are supported and the old license identifiers are deprecated.So using the "new" license identifier would fail the validation for Composer < 1.6.0, using the old license identifier would fail the validation for Composer 1.6.0+. By ignoring warnings, this issue is bypassed.
Refs: