NewInterfaces/Classes: add recognition of return type declarations #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For single token return type declarations, the existing `Sniff::getReturnTypeHintToken()` method is sufficient to figure out whether a return type is used and what it is. However for class and interface based return declarations which may be preceeded by a namespace with namespace separators, just having access to the classname is not sufficient. This new method allows to retrieve the full name of the return type declaration in a manner which is PHPCS cross-version compatible.
…declaration Verification whether interfaces added in newer PHP versions were being used as return type declarations was missing from the sniff. This fixes that. Uses the new `Sniff::getReturnTypeHintName()` method. Includes unit tests.
…ations Verification whether classes added in newer PHP versions were being used as return type declarations was missing from the sniff. This fixes that. Uses the new `Sniff::getReturnTypeHintName()` method. Includes unit tests.
wimg
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification whether interfaces/classes added in newer PHP versions were being used as return type declarations was missing from the sniffs.
This fixes that.
Uses the new
Sniff::getReturnTypeHintName()method which has been added to theSniffclass in a separate commit.Includes unit tests.