PHP 5.6: New sniff to detect constant scalar expressions #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usly only static values were allowed. > It is now possible to provide a scalar expression involving numeric and string literals and/or constants in contexts where PHP previously expected a static value, such as constant and property declarations and default function arguments. Ref: http://php.net/manual/en/migration56.new-features.php#migration56.new-features.const-scalar-exprs Includes extensive unit tests. Notes: * The sniff has been set up in a way that the `HeredocInitialize` sniff will be able to extend it in the near future as that sniff ought to use the same base logic as is contained in the `process()` method (it currently doesn't examine all possible cases to which the heredoc change applies). * I've ran the sniff over some 200.000 files in the WP plugin & theme directory to test against false positives and I've fixed all false positives which I found.
jrfnl
force-pushed
the
php5.6/399-scalar-expressions
branch
from
ddf2a0e
to
9565679
Compare
wimg
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… where previously only static values were allowed.
Refs:
Includes extensive unit tests.
Notes:
HeredocInitializesniff will be able to extend it in the near future as that sniff ought to use the same base logic as is contained in theprocess()method of this sniff (TheHeredocInitializesniff currently doesn't examine all possible cases to which the heredoc change applies).Fixes #399