WordPress ruleset: account for more polyfills and improve documentation #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
* Added `exclude`s for `json_encode()`, `json_decode()` and `hash_hmac()`.
* Added `exclude`s for the SPL autoload polyfills as introduced in WP 4.6.0.
* Added `exclude`s for the new polyfills `is_iterable()` and `is_countable()` as introduced in WP 4.9.6.
* Reorganized the excludes and improved the documentation:
- Group the excludes by the file which contains them.
- Order the excludes to mirror the order in which they appear in the file for easier verification & future maintenance.
|
@jrfnl Is there an ETA on this landing? We're about to re-audit all the themes/plugins with Tide tomorrow and this seems very relevant to getting valid results. |
jrfnl
added
PR: high priority
PR: quick merge
wimg
approved these changes
Jun 9, 2018
|
Merci! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
excludes forjson_encode(),json_decode()andhash_hmac().excludes for the SPL autoload polyfills as introduced in WP 4.6.0.excludes for the new polyfillsis_iterable()andis_countable()as introduced in WP 4.9.6.N.B.: some of the excluded codes relate to functions we currently don't detect yet. There is an upcoming PR to add detection of those, which will be pulled once #640 has been merged to prevent conflicts.