Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the framework/CMS rulesets #694

Merged
merged 1 commit into from Jul 16, 2018
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 15, 2018

... in favour of having them in their own repositories.

⚠️ This PR should only be merged once PR #689, PR PHPCompatibility/PHPCompatibilityJoomla#1 and PR PHPCompatibility/PHPCompatibilityWP#1 have been merged.

Notes:

  • Removed the framework specific rulesets from this repo.

  • Remove the framework ruleset specific build tests from the .travis.yml script.

  • Adjusted the information in the Readme to point to the dedicated repos and add information about the PHPCompatibilityAll repo.

  • Adjusted the information in the Contributing.md file.

    I've chosen to leave the general framework/CMS ruleset guidelines in the Contributing file so they are available to people who want to add a new ruleset for a framework/CMS not yet covered.

Related to #688

@jrfnl jrfnl added chores/QA PR: quick merge PR only contains relatively simple changes PR: ready for review labels Jul 15, 2018
@jrfnl jrfnl added this to the 8.2.0 milestone Jul 15, 2018
@jrfnl jrfnl requested a review from wimg July 15, 2018 23:08
@jrfnl
Copy link
Member Author

jrfnl commented Jul 15, 2018

Workflow to get everything merged & builds to pass:

... in favour of having them in their own repositories.

:warning: This PR should only be merged once PR 689, PR PHPCompatibility/PHPCompatibilityJoomla 1 and PR PHPCompatibility/PHPCompatibilityWP 1 have been merged.

Notes:
* Removed the framework specific rulesets from this repo.
* Remove the framework ruleset specific build tests from the `.travis.yml` script.
* Adjusted the information in the `Readme` to point to the dedicated repos and add information about the `PHPCompatibilityAll` repo.
* Adjusted the information in the `Contributing.md` file.

    I've chosen to leave the general framework/CMS ruleset guidelines in the `Contributing` file so they are available to people who want to add a new ruleset for a framework/CMS not yet covered.
@jrfnl jrfnl force-pushed the feature/remove-framework-rulesets branch from 269fc0e to dedf454 Compare July 16, 2018 14:04
@wimg wimg merged commit 2394bf7 into master Jul 16, 2018
@wimg wimg deleted the feature/remove-framework-rulesets branch July 16, 2018 14:35
@jrfnl jrfnl removed the PR: quick merge PR only contains relatively simple changes label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants