PHP 7.0: New sniff to detect direct calls to __clone() #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/629-new-direct-calls-to-clone-sniff
branch
from
d9734b5
to
9ef0729
Compare
|
Note: the build failure is unrelated to this PR, but has to do with an upstream change - see squizlabs/PHP_CodeSniffer#1574 - for which I have a PR ready. I will pull that PR once PR squizlabs/PHP_CodeSniffer#2215 has been merged, which fixes an oversight in the commit fixing squizlabs/PHP_CodeSniffer#1574. |
> Directly calling __clone is allowed > > Doing calls like $obj->__clone() is now allowed. This was the only magic method that had a compile-time check preventing some calls to it, which doesn't make sense. If we allow all other magic methods to be called, there's no reason to forbid this one. Ref: https://wiki.php.net/rfc/abstract_syntax_tree#directly_calling_clone_is_allowed Includes unit tests. Fixes 629 Note: PR includes minor adjustments to the PHPCompatibility native PHPCS ruleset to allow for the new docblock format as per 734. This will be further addressed in a separate PR dedicated to that issue.
jrfnl
force-pushed
the
feature/629-new-direct-calls-to-clone-sniff
branch
from
9ef0729
to
88ffb64
Compare
|
Rebased. Build should now be able to pass. |
jrfnl
changed the title
wimg
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://wiki.php.net/rfc/abstract_syntax_tree#directly_calling_clone_is_allowed
Includes unit tests.
Fixes #629
Note: PR includes minor adjustments to the PHPCompatibility native PHPCS ruleset to allow for the new docblock format as per #734. This will be further addressed in a separate PR dedicated to that issue.