QA: add use statements for the aliased PHPCS and PHPUnit classes
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For those classes which have 1-on-1 aliases across PHPCS versions, we can use `use ... as ...` statements to import the aliased class and use a shorter reference inline. This applies to: * `PHP_CodeSniffer_File` - aliased as `File` which is the PHPCS 3.x class name. * `PHP_CodeSniffer_Tokens` - aliased as `Tokens` which is the PHPCS 3.x class name. * `PHP_CodeSniffer_Exception` - in PHPCS 3.x, this class is called `PHP_CodeSniffer\Exceptions\RuntimeException`, aliased to `PHPCS_Exception` to prevent confusion with the PHP native `RuntimeException` class. * `Generic_Sniffs_NamingConventions_CamelCapsFunctionNameSniff` - aliased as `PHPCS_CamelCapsFunctionNameSniff`. * `PHP_CodeSniffer_Standards_AbstractScopeSniff` - aliased as `PHPCS_AbstractScopeSniff` to prevent confusion with the PHPCompatibility native abstract sniffs. Note: this is not possible for those classes which don't have a direct counter-part between PHPCS 2 and PHPCS 3! Additionally, the references to the PHPUnit class - which is aliased within the `phpunit-bootstrap.php` file - have also been changed to `use` statements.
wimg
approved these changes
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those classes which have 1-on-1 aliases across PHPCS versions, we can use
use ... as ...statements to import the aliased class and use a shorter reference inline.This applies to:
PHP_CodeSniffer_File- aliased asFilewhich is the PHPCS 3.x class name.PHP_CodeSniffer_Tokens- aliased asTokenswhich is the PHPCS 3.x class name.PHP_CodeSniffer_Exception- in PHPCS 3.x, this class is calledPHP_CodeSniffer\Exceptions\RuntimeException, aliased toPHPCS_Exceptionto prevent confusion with the PHP nativeRuntimeExceptionclass.Generic_Sniffs_NamingConventions_CamelCapsFunctionNameSniff- aliased asPHPCS_CamelCapsFunctionNameSniff.PHP_CodeSniffer_Standards_AbstractScopeSniff- aliased asPHPCS_AbstractScopeSniffto prevent confusion with the PHPCompatibility native abstract sniffs.Note: this is not possible for those classes which don't have a direct counter-part between PHPCS 2 and PHPCS 3!
Additionally, the references to the PHPUnit class - which is aliased within the
phpunit-bootstrap.phpfile - have also been changed tousestatements.