PHP 7.4: New NewPHPOpenTagEOF sniff #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> `<?php` at the end of the file (without trailing newline) will now be interpreted as an opening PHP tag. > Previously it was interpreted either as `<? php` and resulted in a syntax error (with short_open_tag=1) or was interpreted as a literal `<?php` string (with short_open_tag=0). Refs: * https://github.com/php/php-src/blob/30de357fa14480468132bbc22a272aeb91789ba8/UPGRADING#L37-L40 * php/php-src@c9acc90#diff-7748eb3bfdd3bf962553f6f9f2723c45 ## Implementation notes: This sniff will not work on PHP 5.3 in combination with PHPCS < 2.6.0 with `short_open_tag=On` due to a tokenizer bug in PHPCS itself in those older versions. Related: 835 The sniff needs different code to detect the issue depending on whether or not `short_open_tag`s is enabled on the system running the sniffs. By default, the Travis images have `short_open_tag=Off`. To make sure that both situations are unit tested, two of the existing builds will now change the PHP ini config of the Travis image to ensure that the sniff is also tested with `short_open_tag=On`.
jrfnl
force-pushed
the
php-7.4/new-newstandalonephpopentag-sniff
branch
from
65d48b9
to
f49f31c
Compare
wimg
approved these changes
Jul 22, 2019
delete-merged-branch
bot
deleted the
php-7.4/new-newstandalonephpopentag-sniff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
Related to #808
Implementation notes:
This sniff will not work on PHP 5.3 in combination with PHPCS < 2.6.0 with
short_open_tag=Ondue to a tokenizer bug in PHPCS itself in those older versions.Related: #835
The sniff needs different to sniff for different token codes to detect the issue depending on whether or not
short_open_tags is enabled on the system running the sniffs.By default, the Travis images have
short_open_tag=Off.To make sure that both situations are unit tested, two of the existing builds will now change the PHP ini config of the Travis image to ensure that the sniff is also tested with
short_open_tag=On.