pFilename is required parameter for save #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sapfeer0k : Good job, you're right. Could you add changes in changelog.md (https://github.com/PHPOffice/PHPPowerPoint/blob/master/CHANGELOG.md) ? |
|
We have to change |
|
@sapfeer0k : Some news ? |
|
Sorry, for a long answer.. I've been busy... |
Progi1984
added a commit
that referenced
this pull request
Jun 10, 2014
pFilename is required parameter for save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, folks!
I hope you'll find this pull request worthy. That isn't a good idea to pass invalid parameter value by default.
There are two solutions: the first one - assign right filepath (which isn't actually good, cause we don't know wich path is right for user, it may depends on many factors, such as OS, security, etc..) , and the second, which I choosed, mark this parameter as required and check it before use.
Any comments, taughts are very appreciated.