Merge pull request #555 from surger/patch-1

Defining width & height of a shape don't return any error if width & height were equal to 0
PHPOffice · Oct 15, 2019 · 344c779 · 344c779
2 parents 6dc7fc2 + a4b5fce
commit 344c779
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Bugfix
 - PowerPoint2007 : Text is subscripted when set superscript to false - @qmachard GH-360
+- Core : Defining width & height of a shape don't return any error if width & height were equal to 0 - @surger GH-555
 
 ### Changes
 - Dropped support for HHVM - @sunspikes GH-556

diff --git a/src/PhpPresentation/Shape/AbstractGraphic.php b/src/PhpPresentation/Shape/AbstractGraphic.php
@@ -157,7 +157,7 @@ public function setDescription($pValue = '')
     public function setWidth($pValue = 0)
     {
         // Resize proportional?
-        if ($this->resizeProportional && $pValue != 0) {
+        if ($this->resizeProportional && $pValue != 0 && $this->width != 0) {
             $ratio         = $this->height / $this->width;
             $this->height = (int) round($ratio * $pValue);
         }
@@ -177,7 +177,7 @@ public function setWidth($pValue = 0)
     public function setHeight($pValue = 0)
     {
         // Resize proportional?
-        if ($this->resizeProportional && $pValue != 0) {
+        if ($this->resizeProportional && $pValue != 0 && $this->height != 0) {
             $ratio        = $this->width / $this->height;
             $this->width = (int) round($ratio * $pValue);
         }