Defining width & height of a shape don't return any error if width & height were equal to 0 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @surger, thank you for your contribution. Could you update the CHANGELOG.md and add a test in tests/PhpPresentation/Tests/Shape/AbstractGraphicTest.php before merge ? Thanks |
|
@Progi1984 Which version should I specify CHANGELOG.md? And my commit so little, you may miss my commit :). |
|
@surger The next version is 0.10. No, each commit, each contribution is a part of next version. Ok for no tests. You're right. |
|
@surger Could you apply the same logic to the method setWidth ? And update Changelog.md 😉 After that I will merge it. |
Add zero check before divizion
Add zero check before divizion
Progi1984
changed the title
|
Thank you @surger for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zero check before divizion