Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html writer auto invert text color #1387

Merged

Conversation

SailorMax
Copy link
Contributor

Description

Setup table's cell background color and, if require, inverted foreground color.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@coveralls
Copy link

coveralls commented May 24, 2018

Coverage Status

Coverage increased (+0.005%) to 94.629% when pulling 8931ab1 on SailorMax:html_writer_auto_invert_text_color into 81af913 on PHPOffice:develop.

@troosan
Copy link
Contributor

troosan commented May 31, 2018

@SailorMax Nice feature! Could you write a little unit test to cover this?

@troosan troosan added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Dec 27, 2018
@troosan troosan removed the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Mar 4, 2019
@troosan troosan added this to the v0.17.0 milestone Mar 4, 2019
@troosan troosan merged commit 2d2fe52 into PHPOffice:develop Mar 5, 2019
@SailorMax SailorMax deleted the html_writer_auto_invert_text_color branch March 6, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants