PHP 8.1 compatability fix for PreserveText and XMLWriter #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, merge that request. Thanks |
I join |
|
Yes please merge that PR! |
|
What needs to be done to make it work? |
|
It works. It just needs to be merged. If you can't wait for the maintainers to merge it, then you can fork our repo and run with that until this one gets merged. |
|
@mal-risma Yes... But it doesn't work well for a few features( |
3 tasks
|
Could you please try to find a solution for that and merge it! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues with deprecation warnings in PHP 8.1.
The check script fails with an error in an unrelated file, so I'm guessing that's ok:
/application/repos/PHPWord/src/PhpWord/Element/TOC.php:27 CamelCasePropertyName The property $TOCStyle is not named in camelCase.All unit tests still pass on PHP 7.3.
Checklist:
composer run-script check --timeout=0and no errors were reported