PHP 8.1 Support for addPreserveText #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
third parameter must be -1 not null (php 8.1 deprecate warning)
add #[\ReturnTypeWillChange] Attribute to the function writeAttribute (php 8.1 deprecate warning)
|
Would love to see this one merged since we need this to upgrade our stack to PHP 8.1. Also I imagine this relates to #2209 ? |
|
This along with all the other php8.1 related deprecations need to be merged. |
|
@PowerKiKi You helped to merge, tag, and release #2187 which was another PHP 8.1 fix. Is there any chance you might be able to help with this one, and also #2292 and #2272? Or @Progi1984 ? |
Progi1984
approved these changes
Sep 14, 2022
|
Thanks @cscrewsandcaptains for the contribution Thansk @garethellis36 for the ping. |
|
Thanks folks, any chance of a tagged release please? :) |
|
I also wait after this release (v0.18.4 ? ^^) to validate the migration to PHP8.1 of all my application ;) |
|
released as 1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.1 Support for addPreserveText
Fixes #2220
Checklist:
composer run-script check --timeout=0and no errors were reported (** scripts not run with PHP 8.1 (without my changes!) **)