Skip to content

Commit

Permalink
Drop PHP 5.6 and 7.0
Browse files Browse the repository at this point in the history
This is according to our formal, published, policy to only support
eol PHP after 6 months.

See https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support
  • Loading branch information
PowerKiKi committed Jul 25, 2019
1 parent dbc8777 commit 454d942
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 22 deletions.
3 changes: 0 additions & 3 deletions .travis.yml
Expand Up @@ -2,8 +2,6 @@ language: php
dist: trusty

php:
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3
Expand All @@ -12,7 +10,6 @@ php:
matrix:
fast_finish: true
allow_failures:
- php: 5.6
- php: 7.4snapshot

cache:
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Expand Up @@ -35,11 +35,11 @@
"php-cs-fixer fix --ansi"
],
"versions": [
"phpcs --report-width=200 samples/ src/ tests/ --ignore=samples/Header.php --standard=PHPCompatibility --runtime-set testVersion 5.6- -n"
"phpcs --report-width=200 samples/ src/ tests/ --ignore=samples/Header.php --standard=PHPCompatibility --runtime-set testVersion 7.1- -n"
]
},
"require": {
"php": "^5.6|^7.0",
"php": "^7.1",
"ext-ctype": "*",
"ext-dom": "*",
"ext-gd": "*",
Expand Down Expand Up @@ -84,4 +84,4 @@
"PhpOffice\\PhpSpreadsheetTests\\": "tests/PhpSpreadsheetTests"
}
}
}
}
6 changes: 3 additions & 3 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions docs/index.md
Expand Up @@ -25,12 +25,9 @@ spreadsheet file formats, like Excel and LibreOffice Calc.

## Software requirements

The following software is required to develop using PhpSpreadsheet:

- PHP version 5.6 or newer
- PHP extension php\_zip enabled
- PHP extension php\_xml enabled
- PHP extension php\_gd2 enabled (if not compiled in)
PHP version 7.1 or newer to develop using PhpSpreadsheet. Other requirements, such as PHP extensions, are enforced by
composer. See the `require` section of [the composer.json file](https://github.com/PHPOffice/PhpSpreadsheet/blob/master/composer.json)
for details.

### PHP version support

Expand Down
2 changes: 1 addition & 1 deletion samples/index.php
Expand Up @@ -3,7 +3,7 @@
require_once 'Header.php';

$requirements = [
'PHP 5.6.0' => version_compare(PHP_VERSION, '5.6.0', '>='),
'PHP 7.1.0' => version_compare(PHP_VERSION, '7.1.0', '>='),
'PHP extension XML' => extension_loaded('xml'),
'PHP extension xmlwriter' => extension_loaded('xmlwriter'),
'PHP extension mbstring' => extension_loaded('mbstring'),
Expand Down
2 changes: 0 additions & 2 deletions src/PhpSpreadsheet/Settings.php
Expand Up @@ -30,7 +30,6 @@ class Settings
* 7.2 < 7.2.1
* 7.1 < 7.1.13
* 7.0 < 7.0.27
* 5.6 ANY
* then you may need to disable this check to prevent unwanted behaviour in other threads
* SECURITY WARNING: Changing this flag is not recommended.
*
Expand Down Expand Up @@ -122,7 +121,6 @@ public static function getLibXmlLoaderOptions()
* 7.2 < 7.2.1
* 7.1 < 7.1.13
* 7.0 < 7.0.27
* 5.6 ANY
* then you may need to disable this check to prevent unwanted behaviour in other threads
* SECURITY WARNING: Changing this flag to false is not recommended.
*
Expand Down
4 changes: 0 additions & 4 deletions tests/PhpSpreadsheetTests/Cell/CoordinateTest.php
Expand Up @@ -243,10 +243,6 @@ public function testBuildRangeInvalid()
{
$this->expectException(\TypeError::class);

if (PHP_MAJOR_VERSION < 7) {
$this->markTestSkipped('Cannot catch type hinting error with PHP 5.6');
}

$cellRange = '';
Coordinate::buildRange($cellRange);
}
Expand Down

2 comments on commit 454d942

@mcouillard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems important to note in the release notes of tag 1.9 because it differs from 1.8 and below

@PowerKiKi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in a972943

Please sign in to comment.