Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: delete $ #1095

Closed
wants to merge 1 commit into from
Closed

bug fix: delete $ #1095

wants to merge 1 commit into from

Conversation

vagren
Copy link

@vagren vagren commented Jul 19, 2019

This is:

- [ ] a bugfix

Checklist:

Why this change is needed?

bug: Allowed memory size of xxx bytes exhausted at xxx:xxx (tried to allocate xxx bytes)

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should most likely be done in \PhpOffice\PhpSpreadsheet\Worksheet\Worksheet::shrinkRangeToFit instead of in the reader. Or maybe even deeper in code, depending on where the bug actually occur.

But most importantly it should be covered by unit tests.

@stale
Copy link

stale bot commented Sep 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Sep 23, 2019
@stale stale bot closed this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants